<functional>
: Make default_searcher
ADL-proof
#4379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #4004. Towards #140.
This PR makes
default_searcher
ADL-proof and makesboyer_moore_searcher
andboyer_moore_horspool_searcher
accept ADL-incompatible functors.Currently, internal function calls involving program-defined types and
std::swap
calls are_STD
-qualified, while other internal functions (which only involvevoid*
and integers) are not.There're some difficulties in making
boyer_moore_searcher
andboyer_moore_horspool_searcher
accept ADL-incompatible element types: see #4380.