Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<mdspan>: Construct mappings from extents_type rvalues when necessary #4236

Merged
merged 1 commit into from
Dec 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stl/inc/mdspan
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,8 @@ struct _Mdspan_mapping_base {

constexpr explicit _Mdspan_mapping_base(const _Extents& _Exts) : _Map(_Exts) {}

constexpr explicit _Mdspan_mapping_base(_Extents&& _Exts) : _Map(_STD move(_Exts)) {}

template <class _OtherMapping>
constexpr explicit _Mdspan_mapping_base(const _OtherMapping& _Map_) : _Map(_Map_) {}

Expand All @@ -1091,6 +1093,8 @@ struct _Mdspan_mapping_base<_Extents, _LayoutPolicy> {

constexpr explicit _Mdspan_mapping_base(const _Extents&) noexcept {}

constexpr explicit _Mdspan_mapping_base(_Extents&&) noexcept {}

template <class _OtherMapping>
constexpr explicit _Mdspan_mapping_base(const _OtherMapping& _Map_) {
// NB: Constructing _Mapping from _OtherMapping may have side effects - we should create a temporary.
Expand Down