fboemer/hexl-1.1.0 #332
Merged
fboemer/hexl-1.1.0 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiDaiWD
reviewed
May 11, 2021
|
In benchmark results, |
WeiDaiWD
reviewed
May 11, 2021
WeiDaiWD
reviewed
May 11, 2021
WeiDaiWD
reviewed
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to HEXL v1.1.0:
Integrates hexl::EltwiseReduceMod (for SEAL
modulo_poly_coeffs, i.e. Barrett reduce 64)Integrates hexl::EltwiseAddMod / hexl::EltwiseSubMod
Uses memory pool wrapper around NTT allocations. This way, the reported memory allocation reported by SEAL is more accurate, since it includes memory allocated by HEXL as well.
Fixes failing tests when SEAL_USE_ZLIB=OFF and SEAL_USE_ZTD=OFF
Fixes shared library build when SEAL_USE_HEXL=ON
See below for performance improvement compared to previous HEXL integration. Data generated from the N=8192 / log(q) = 218 benchmark with 1000 iterations. Note, we see occasional slowdowns in some functions, e.g. in
EvaluateAddCt. This slowdown does not seem to persist across compilations.