Validators/permissive multiples #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
reviewed
Nov 6, 2017
qcodes/tests/test_validators.py
Outdated
| print(div, mult) | ||
| val.validate(mult) | ||
|
|
||
| # finally, a quick test that the precision is indeed setable |
There was a problem hiding this comment.
Woops... nice catch.
jenshnielsen
reviewed
Nov 6, 2017
| divs = int(divmod(value, self.divisor)[0]) | ||
| true_vals = np.array([n*self.divisor for n in range(divs, divs+2)]) | ||
| abs_errs = [abs(tv-value) for tv in true_vals] | ||
| if min(abs_errs) > self.precision: |
There was a problem hiding this comment.
Should this have a relative tolerance too?
There was a problem hiding this comment.
Mimicking np.allclose? I am a bit undecided. I think for most cases it will suffice to say "be precise to within 0.5 nV".
There was a problem hiding this comment.
Yes as long as people are not using "strange" units its fine, we can always add later if needed
|
2 Inline comments otherwise looks good |
jenshnielsen
approved these changes
Nov 7, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 7, 2017
Author: William H.P. Nielsen <whpn@mailbox.org>
Validators/permissive multiples (#852)
giulioungaretti
pushed a commit
that referenced
this pull request
Nov 7, 2017
Author: William H.P. Nielsen <whpn@mailbox.org>
Validators/permissive multiples (#852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765
Changes proposed in this pull request:
The new validator,
PermissiveMultiplesallows integer multiples of a given base value to slip through. It allows negative multiples as well, and therefore by definition always 0. It is subject to rounding errors, so a user-specificied absolute precision is in principle required.@jenshnielsen