-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/control parameters plotted in plot dataset #6931
base: main
Are you sure you want to change the base?
Feature/control parameters plotted in plot dataset #6931
Conversation
…ttps://github.com/harrietoxinst/Qcodes into feature/control-parameters-plotted-in-plot_dataset
…ttps://github.com/harrietoxinst/Qcodes into feature/control-parameters-plotted-in-plot_dataset
@microsoft-github-policy-service agree company="Oxford Instruments" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6931 +/- ##
==========================================
- Coverage 69.39% 68.29% -1.10%
==========================================
Files 341 341
Lines 31399 31419 +20
==========================================
- Hits 21788 21459 -329
- Misses 9611 9960 +349 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Thanks for reviewing. I have committed the suggested change and fixed the errors for pre-commit check. |
This PR introduces a
parameters
argument to theplot_dataset
function such that not all dependent parameters have to be plotted if this behaviour is not desired. This closes #6898 . Motivation for this change is further outlined there.Default behaviour of
plot_dataset
remains unchanged. I have also added theparameters
argument to theplot_by_id
function preserving the equivalent behaviour shared byplot_by_id
andplot_dataset
.To provide an example of when/how this might be used I have added the following under 1.2 Two interleaved 1D sweeps in the Offline Plotting Tutorial notebook: