-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oxford ips driver new parameters #6889
Oxford ips driver new parameters #6889
Conversation
…tching the status of magnet heater.
… important temperatures of magnet, PT1 and PT2. Also add a parser to the start for parsing the temperature from response
@microsoft-github-policy-service agree |
Thanks @panasee looks good. Left one inline question and a missing type hint. Also please have a look at the precommit job and fix any issue there and then this is ready to merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6889 +/- ##
=======================================
Coverage 69.38% 69.39%
=======================================
Files 341 341
Lines 31386 31399 +13
=======================================
+ Hits 21776 21788 +12
- Misses 9610 9611 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
…/panasee/Qcodes into oxford-ips-driver-new-parameters
Hello, I've fixed all the issues on my side. Please have a look. |
Description
Added several parameters into the oxford MercuryiPS driver, enabling the control of the heaters and the sensing of internal temperatures (magnet, PT1, and PT2 stage of cryogenic system). The new driver has been tested on a real-world iPS device with only a z-axis magnet and all three temperature sensors.
Implementation details
This pull request includes several updates to the
src/qcodes/instrument_drivers/oxford/MercuryiPS_VISA.py
file, focusing on adding new parameters and a parser function. The most important changes include the addition of a temperature parser function and new parameters for heater switch and temperature readings.New Parser Function:
_temp_parser
function to parse response strings into SI temperature values.New Parameters:
heater_switch
parameter to manage the heater switch status and settings. The heater switch control is bound to each WorkerPS, accepting "ON" and "OFF" as inputs.magnet_temp
,pt1_temp
, andpt2_temp
parameters for reading temperatures from different sensors, utilizing the new_temp_parser
function. The addresses of sensors are stored statically within the overall iPS classBreaking Changes
No breaking changes. But I am not sure if the heaters and temperature sensors exist for all MercuryiPS instruments.
Currently, the addresses of temperature sensors are written statically in the driver. Not sure if they could change across different systems.