Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround broken docstrings in the python std library #5979

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

jenshnielsen
Copy link
Collaborator

This overwrites two methods that have broken docstrings in the std library. Note that a proper fix is in python/cpython#117847

This in turn will allow us to enable warnings as errors once again in the docs build

@jenshnielsen jenshnielsen requested a review from a team as a code owner April 18, 2024 06:11
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.42%. Comparing base (e5975a1) to head (185b688).

Files Patch % Lines
...nstrument_drivers/Lakeshore/Lakeshore_model_325.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5979      +/-   ##
==========================================
- Coverage   67.42%   67.42%   -0.01%     
==========================================
  Files         349      349              
  Lines       30201    30206       +5     
==========================================
+ Hits        20364    20367       +3     
- Misses       9837     9839       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Apr 29, 2024
Merged via the queue into microsoft:main with commit 0f8dea0 Apr 29, 2024
18 of 20 checks passed
@jenshnielsen jenshnielsen deleted the fix_docstring branch April 29, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants