Add CopyFiles step #416
Closed
Add CopyFiles step #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dantler |
ironyman
pushed a commit
to ironyman/PowerToys
that referenced
this pull request
Feb 20, 2025
This is just a very rough prototype of "TextToSuggest", to make it do _something_. I'll link this to microsoft#358, but it's not clean enough to close it. I just slapped a TextBlock with the suggested text to the right of the input, just so users can see that there is a suggestion and that you can press `right` to accept it. The best extension to test this with is the Registry one, but that crashes heavily in `ListHelpers.InPlaceUpdateList`. I think it's for two reasons: * a null item in the list? (we should ignore that!) * and we're modifying the list as we're updating it (definitely shouldn't do that) I'm guessing the second is actually the cause of microsoft#324, though I've had a hard time reproing that as of late.
ironyman
pushed a commit
to ironyman/PowerToys
that referenced
this pull request
Feb 20, 2025
In microsoft#416 I tried to lock the lists before we modify them. Problem was, on L143 I only locked the `FilteredItems`, when `Items` can change there too. One singular lock for both makes the most sense anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing your CI infrastructure.
Copy and pasted exactly from MSDN:
https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/build-artifacts?view=azure-devops&tabs=yaml
Summary of the Pull Request
Attempting to fix #415 .