Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix building on Visual Studio 17.8 #29303

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Tried building PowerToys

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Build local installer using the Visual Studio 17.8.0 Preview 4.0.
Checking if CI still passes on current versions.

@github-actions

This comment has been minimized.

@jaimecbernardo jaimecbernardo marked this pull request as ready for review October 19, 2023 10:23
@jaimecbernardo
Copy link
Collaborator Author

@snickler , FYI. Just in case you need some for the .NET 8 PR :)

Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂

@snickler
Copy link
Collaborator

@snickler , FYI. Just in case you need some for the .NET 8 PR :)

Perfect!

@jaimecbernardo jaimecbernardo merged commit f0b4603 into main Oct 19, 2023
@jaimecbernardo jaimecbernardo deleted the dev/jaime/fix-vs17.8-build branch October 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants