Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PowerRename GIF #27499

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Replace PowerRename GIF #27499

merged 4 commits into from
Aug 4, 2023

Conversation

ChaseKnowlden
Copy link
Contributor

@ChaseKnowlden ChaseKnowlden commented Jul 18, 2023

Summary of the Pull Request

Replace the outdated PowerRename GIF with a new one.

Part of #14182

PR Checklist

Detailed Description of the Pull Request / Additional comments

The GIF in the repo is outdated.

Validation Steps Performed

Open OOBE.

@niels9001 niels9001 self-requested a review July 18, 2023 14:03
@Jay-o-Way
Copy link
Collaborator

Would this solve #27496?

@blush-petal
Copy link

Would this solve #27496?

New GIF could solve #27496 for PowerRename utility but the issue occurs in GIFs to almost all utilities, so the issue would be solved partially.

@stefansjfw
Copy link
Collaborator

New gif is nice. However, it would be nice to have the same gif without last used "Search for" (firefox) and "Replace with" strings

@jaimecbernardo
Copy link
Collaborator

@ChaseKnowlden , can you please address @stefansjfw 's feedback? Other than that, this would be good to go in. Thank you for the contribution.

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jul 26, 2023

Please also include the new image in the next update of the MS Store info for PT.

@ChaseKnowlden
Copy link
Contributor Author

Fixed my gif @stefansjfw

Copy link
Collaborator

@stefansjfw stefansjfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good now

@niels9001
Copy link
Contributor

niels9001 commented Aug 1, 2023

@chaseknowden Does this GIF has the same aspect ratio and dimensions compared to the other gifs used for other modules? Things might be cut off otherwise..

@ChaseKnowlden
Copy link
Contributor Author

ChaseKnowlden commented Aug 1, 2023

Fixed resolution of GIF to make it fit into the OOBE window @niels9001.

@stefansjfw stefansjfw merged commit bcaca18 into microsoft:main Aug 4, 2023
@ChaseKnowlden ChaseKnowlden deleted the replace-powerrename-image branch August 4, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants