Fix/improve settings/oobe text #22276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Descriptions don't need a period, unless they're full sentences.
the 3 changes from bold to code are for readability
niels9001
reviewed
Nov 24, 2022
niels9001
reviewed
Nov 24, 2022
niels9001
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
LGTM! Nice work @Jay-o-Way and great to see this kind of polish :)!
Would be nice to have something better for the serif stuff.
crutkas
reviewed
Nov 25, 2022
jaimecbernardo
approved these changes
Nov 29, 2022
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| <StackPanel Orientation="Vertical"> | |||
| <labs:SettingsCard | |||
| x:Uid="QuickAccent_EnableQuickAccent" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We missed one incorrect uid
tweaked some .descriptions
tweaked some OOBE text, regarding OOBE strings: which words should be bold? #20200 - e.g.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed