Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xaml adjustments, including contributors #2118

Merged
merged 2 commits into from
Apr 14, 2020
Merged

xaml adjustments, including contributors #2118

merged 2 commits into from
Apr 14, 2020

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Apr 14, 2020

Summary of the Pull Request

Adding in the attribution

References

PR Checklist

  • [] Applies to Giving attribution for authors of PowerToys #862
  • [] CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas crutkas added the Product-Settings The standalone PowerToys Settings application label Apr 14, 2020
udit3333
udit3333 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@udit3333 udit3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crutkas crutkas merged commit 95eb17b into dev/build-features Apr 14, 2020
@crutkas crutkas deleted the dev/cruktas/SettingsTweaks branch April 14, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udit3333 udit3333 udit3333 approved these changes

Assignees
No one assigned
Labels
Product-Settings The standalone PowerToys Settings application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crutkas @udit3333