Arm64 bootstrapper #18241
Merged
Arm64 bootstrapper #18241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
known issues: - wix doesn't have arm platform -> using x86 instead, resulting in wrong default installation dir and inability to detect 605 - current winappsdk 1.0.3 installer is corrupted -> contains x64 packages - we're still using hardcoded vcredist for some modules
|
@snickler is also welcome to review 🤗 |
Yup I'm doing that now :) |
stefansjfw
reviewed
May 13, 2022
There was a problem hiding this comment.
few more notes beside other comments:
- what's the name of the arm build dir? Should it be added to .gitignore?
- PowerToysSetpCustomActions proj doesn't have ARM64 targets. Needed or not?
version_architecture get_current_architecture()in version.cpp has ARM TODO
|
Also, searching for "VideoConferenceProxyFilter_ARM64" in entire project looks like it's missing in some places, comparing to "VideoConferenceProxyFilter_x64" |
Yeah I noticed that also while building it. I'm going to check and see what's up with that. |
|
@yuyoyuppe @stefansjfw are you able to compile |
@snickler |
|
@stefansjfw thanks for the review!
good catch, added.
done. it was ignored by something else before.
no, wix doesn't support ARM64 yet, and this dll is being loaded by the installer. we build installer as x86 now.
yes, CI and updating will be done as a separate PR, as well as vcredist cleanup (currently it's hardcoded) @snickler works for me w/o issues. I've pushed a possible fix, please try again. |
|
Hmmm. @yuyoyuppe @stefansjfw. I still get the same error after pulling down the latest. I'm using the latest VS2022 preview, but here's output from running MSBuild in CLI. |
stefansjfw
reviewed
May 13, 2022
|
@snickler pushed another fix attempt. I'm on VS2022 x64 17.1.5. |
Still didn't work. I'm on VS2022 17.3.0 Preview 1.0. I'm going to try and compile this from my x64 device and see if it's any different. |
|
Added perfect forwarding for template <class... _Types>
_NODISCARD wstring format(const wstring_view _Fmt, const _Types&... _Args) {
return _STD vformat(_Fmt, _STD make_wformat_args(_Args...));
} |
Nope same error. It's using MSVC 14.33.31424 template <class... _Types>
_NODISCARD string format(const _Fmt_string<_Types...> _Fmt, _Types&&... _Args) {
return _STD vformat(_Fmt._Str, _STD make_format_args(_Args...));
}
template <class... _Types>
_NODISCARD wstring format(const _Fmt_wstring<_Types...> _Fmt, _Types&&... _Args) {
return _STD vformat(_Fmt._Str, _STD make_wformat_args(_Args...));
}
template <class... _Types>
_NODISCARD string format(const locale& _Loc, const _Fmt_string<_Types...> _Fmt, _Types&&... _Args) {
return _STD vformat(_Loc, _Fmt._Str, _STD make_format_args(_Args...));
}
template <class... _Types>
_NODISCARD wstring format(const locale& _Loc, const _Fmt_wstring<_Types...> _Fmt, _Types&&... _Args) {
return _STD vformat(_Loc, _Fmt._Str, _STD make_wformat_args(_Args...));
} |
|
Oh! Got it! Thanks for sending me your |
@check-spelling-bot Report🔴 Please reviewSee the files view or the action log for details. Unrecognized words (2)vformat Previously acknowledged words that are now absentBGSOUNDS BUILDARCH CLIENTPULL dispid DISPIDAMBIENTDLCONTROL DLACTIVEXCTLS DLCONTROL DLIMAGES DOWNLOADONLY epo FANCYZONESWINDOWSTYLES FORCEOFFLINE FRAMEDOWNLOAD gsuberland HFONT Htmdid ICore IDCANCEL IDOK INITDIALOG IReflect IWindows IXaml lamotile METACHARSET mirophone mshtmdid NETFX netstandard Nvidia otating Postion preperty Redist ruleset RUNACTIVEXCTLS serizalization settingsv Setttings sourceid testtrocess Toolchain VDId xbf XBind XInstanceTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:yuyoyuppe/PowerToys.git repository If the flagged items do not appear to be textIf items relate to a ...
|
|
Nice! |
|
With that change, I was able to build the installer and bootstrapper, then successfully install without issues. |
jaimecbernardo
approved these changes
May 13, 2022
|
Is every PR comment addressed? |
This was referenced Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
This PR is a first part of adding the arm64 support for bootstrapper. Known issues:
What is included in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.