Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KeyVaultClient to SecretClient. #67

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update KeyVaultClient to SecretClient. #67

wants to merge 4 commits into from

Conversation

Tianyun-G
Copy link

@Tianyun-G Tianyun-G commented Jan 21, 2021 •
edited
Loading

Updated: CPVApplication, CSPApplication, PartnerConsent.

  • All these 3 projects updated ..\Utilities\KeyVaultProvider.cs
  • KeyVaultClient updated to SecretClient.

@jongio for notification.

@Tianyun-G Tianyun-G requested a review from a user January 21, 2021 02:58
@Tianyun-G Tianyun-G requested a review from kaminasy as a code owner January 21, 2021 02:58
@kaminasy
Copy link
Contributor

@Tianyun-G is this ready for a review?

@Tianyun-G
Copy link
Author

@kaminasy Yes, please review.

@kaminasy
Copy link
Contributor

@Tianyun-G I have reviewed your PR. Just to confirm for my end. Please confirm whether the application is running with all your changes with no issues.

@kaminasy
Copy link
Contributor

@Tianyun-G I have reviewed your PR. Just to confirm for my end. Please confirm whether the application is running with all your changes with no issues.

Ping?

@Tianyun-G
Copy link
Author

@kaminasy - Hi, the application where I changed compile with no issue. We try to run this application but couldn't find the value of PartnerId and CustomerId link; Do you have any ideas ?

@Tianyun-G
Copy link
Author

Tianyun-G commented May 13, 2021 •
edited
Loading

@kaminasy Do you have any ideas ? Any progress?

@v-xuto
Copy link

v-xuto commented Oct 9, 2021

@kaminasy Do you have any ideas ?

@jongio
Copy link

jongio commented Oct 18, 2021

@kaminasy ?

@kaminasy
Copy link
Contributor

@kaminasy ?

Please find your requested information in the email that I have sent earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshp-ms brijeshp-ms brijeshp-ms approved these changes

@kaminasy kaminasy kaminasy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Tianyun-G @kaminasy @v-xuto @jongio @brijeshp-ms @v-yilinhu