Add codeql suppression #8134
Merged
Add codeql suppression #8134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
reviewed
Jan 8, 2025
bschnurr
reviewed
Jan 8, 2025
| @@ -253,7 +253,7 @@ public static ProcessOutput Run( | |||
| psi.Arguments = string.Join(" ", | |||
| arguments.Where(a => a != null).Select(QuoteSingleArgument)); | |||
| } else { | |||
| psi.Arguments = string.Join(" ", arguments.Where(a => a != null)); | |||
| psi.Arguments = string.Join(" ", arguments.Where(a => a != null)); // CodeQL [SM00406] Code ql is complaining, but this is a utility class that is called with many different file names. | |||
There was a problem hiding this comment.
complaining that we dont verify arguments?
There was a problem hiding this comment.
Yeah so the actual violation is https://liquid.microsoft.com/Web/Object/Read/ScanningToolWarnings/Requirements/CodeQL.SM00406#Zguide. The problem is that we can't possibly validate arguments here, it's a generic helper class to run a command line, we just join the arguments and run. Just red tape.
There was a problem hiding this comment.
so alternatively we look at all the usage points to find a set of strings.. but there will still be some dynamic ones. maybe arg templates safer.
|
StellaHuang95
approved these changes
Jan 8, 2025
bschnurr
approved these changes
Jan 8, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rchiodo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8090
CodeQL doesn't allow you to suppress an warning on an entire file or class, it's per line only.
So even though line 251 already has a suppression, the violation at https://liquid.microsoft.com/codeql/issues/38ae4090-21dd-4617-94cf-6f5f77966286 is now occurring on line 256, so we need another suppression.
That's what this change is.