Fix warning that repeatedly shows up (#7731)

* update versions exposed to users * fix warning repeatedly showing up * update debugpy version
microsoft · Oct 18, 2023 · b72355d · b72355d
1 parent 1fd6cab
commit b72355d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/Build/debugpy-version.txt b/Build/debugpy-version.txt
@@ -1 +1 @@
-1.6.7
+1.8.0
diff --git a/Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs b/Python/Product/PythonTools/PythonTools/LanguageServerClient/PythonLanguageClient.cs
@@ -396,18 +396,6 @@ private LanguageServerSettings.PythonSettings GetSettings(Uri scopeUri = null)
                 PythonConstants.TypeCheckingModeSetting, null, Site, PythonWorkspaceContextProvider.Workspace, out _)
                 ?? _analysisOptions.TypeCheckingMode;
 
-            var ver3 = new Version(3, 0);
-            var version = context.InterpreterConfiguration.Version;
-            // show a warning if the python version is not supported
-            if (version.ToLanguageVersion() == PythonLanguageVersion.None)
-            {
-                MessageBox.ShowWarningMessage(Site, Strings.PythonVersionNotSupportedInfoBarText.FormatUI(context.InterpreterConfiguration.Description));
-            }
-            else if (context.InterpreterConfiguration.Version < ver3)
-            {
-                MessageBox.ShowWarningMessage(Site, Strings.WarningPython2NotSupported);
-            }
-
             // get task list tokens from options
             var taskListTokens = new List<LanguageServerSettings.PythonSettings.PythonAnalysisSettings.TaskListToken>();
             var taskListService = Site.GetService<SVsTaskList, ITaskList>();

diff --git a/Python/Product/PythonTools/PythonTools/Project/PythonProjectNode.cs b/Python/Product/PythonTools/PythonTools/Project/PythonProjectNode.cs
@@ -28,6 +28,7 @@
 using Microsoft.Build.Execution;
 using Microsoft.PythonTools.Commands;
 using Microsoft.PythonTools.Common;
+using Microsoft.PythonTools.Common.Parsing;
 using Microsoft.PythonTools.Environments;
 using Microsoft.PythonTools.Infrastructure;
 using Microsoft.PythonTools.Interpreter;
@@ -273,6 +274,14 @@ internal set {
                             MSBuildConstants.InterpreterIdProperty,
                             ReplaceMSBuildPath(_active.Configuration.Id)
                         );
+                        var ver3 = new Version(3, 0);
+                        var version = _active.Configuration.Version;
+                        // show a warning if the python version is not supported
+                        if (version.ToLanguageVersion() == PythonLanguageVersion.None) {
+                            Utility.MessageBox.ShowWarningMessage(Site, Strings.PythonVersionNotSupportedInfoBarText.FormatUI(_active.Configuration.Description));
+                        } else if (_active.Configuration.Version < ver3) {
+                            Utility.MessageBox.ShowWarningMessage(Site, Strings.WarningPython2NotSupported);
+                        }
                     } else {
                         BuildProject.SetProperty(MSBuildConstants.InterpreterIdProperty, "");
                     }