Only install .NET Monitor 9 on .NET 9 images #2569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the removal was intended to cleanup the rc version with #2540. |
wiktork
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET 9 Oryx images are unconditionally installing the latest .NET Monitor version onto the image. This is opposed to the prior .NET Oryx images where they are range bound to the major version that corresponds with the .NET version. If this constraint is not added, when .NET Monitor releases a newer version that only works on a future version of .NET, image build failure will occur. This change is intended to mitigate that risk by applying the same range bound as the prior images have e.g. https://github.com/microsoft/Oryx/blob/main/images/runtime/dotnetcore/8.0/bookworm.Dockerfile#L9