Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error validating OpenAPI using hidi preview #2076

Merged
merged 2 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static OpenApiRequestBody LoadRequestBody(ParseNode node, OpenApiDocument
var requestBody = new OpenApiRequestBody();
foreach (var property in mapNode)
{
property.ParseField(requestBody, _requestBodyFixedFields, _requestBodyPatternFields);
property.ParseField(requestBody, _requestBodyFixedFields, _requestBodyPatternFields, hostDocument);
}

return requestBody;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1411,5 +1411,17 @@ public async Task ParseDocumentWithEmptyPathsSucceeds()
var result = await OpenApiDocument.LoadAsync(System.IO.Path.Combine(SampleFolderPath, "docWithEmptyPaths.yaml"));
result.Diagnostic.Errors.Should().BeEmpty();
}

[Fact]
public async Task ParseDocumentWithExampleReferencesPasses()
{
// Act & Assert: Ensure no NullReferenceException is thrown
Func<Task> act = async () =>
{
await OpenApiDocument.LoadAsync(System.IO.Path.Combine(SampleFolderPath, "docWithExampleReferences.yaml"));
};

await act.Should().NotThrowAsync<NullReferenceException>();
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
openapi: 3.0.3
info:
version: 1.1.4
title: GitHub v3 REST API
description: GitHub's v3 REST API.
paths:
/actions/hosted-runners/{hosted_runner_id}:
get:
summary: Get a GitHub-hosted runner for an organization
description: |-
Gets a GitHub-hosted runner configured in an organization.
OAuth app tokens and personal access tokens (classic) need the `manage_runners:org` scope to use this endpoint.
responses:
'200':
description: Response
content:
application/json:
schema:
"$ref": "#/components/schemas/actions-hosted-runner"
examples:
default:
"$ref": "#/components/examples/actions-hosted-runner"
/oidc/customization/sub:
get:
summary: Get the customization template for an OIDC subject claim for an organization
description: |-
Gets the customization template for an OpenID Connect (OIDC) subject claim.
OAuth app tokens and personal access tokens (classic) need the `read:org` scope to use this endpoint.
requestBody:
required: true
content:
application/json:
schema:
"$ref": "#/components/schemas/oidc-custom-sub"
examples:
default:
"$ref": "#/components/examples/oidc-custom-sub"
responses:
'200':
description: A JSON serialized template for OIDC subject claim customization
content:
application/json:
schema:
"$ref": "#/components/schemas/oidc-custom-sub"
components:
schemas:
actions-hosted-runner:
title: GitHub-hosted runner
type: object
oidc-custom-sub:
title: Actions OIDC Subject customization
description: Actions OIDC Subject customization
type: object
examples:
actions-hosted-runner:
value:
id: 5
name: My hosted ubuntu runner
runner_group_id: 2
platform: linux-x64
oidc-custom-sub:
value:
include_claim_keys:
- repo
- context



Loading