Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure AOT for trimming compatibility #2063

Merged
merged 16 commits into from
Jan 16, 2025
Merged

feat: configure AOT for trimming compatibility #2063

merged 16 commits into from
Jan 16, 2025

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1875

@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review January 15, 2025 11:22
@MaggieKimani1 MaggieKimani1 marked this pull request as draft January 15, 2025 11:36
baywet
baywet reviewed Jan 15, 2025
View reviewed changes
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@MaggieKimani1 MaggieKimani1 marked this pull request as ready for review January 16, 2025 13:16
@MaggieKimani1 MaggieKimani1 changed the title Configure AOT for trimming compatibility feat: configure AOT for trimming compatibility Jan 16, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.2% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

baywet
baywet approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@MaggieKimani1 MaggieKimani1 merged commit b4f9c3e into dev Jan 16, 2025
13 of 14 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/implement-AOT branch January 16, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2 - should be compatible with AOT/trimming
3 participants
@MaggieKimani1 @andrueastman @baywet