Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/missing culture #2037

Merged
merged 24 commits into from
Jan 3, 2025
Merged

fix/missing culture #2037

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9ff9789
Merge pull request #1846 from microsoft/vnext
MaggieKimani1 Sep 30, 2024
b5b11f5
Merge pull request #1860 from microsoft/vnext
irvinesunday Oct 4, 2024
97f8450
Merge pull request #1873 from microsoft/vnext
irvinesunday Oct 14, 2024
8c64b50
Merge pull request #1885 from microsoft/vnext
irvinesunday Oct 22, 2024
3e0a83f
Merge pull request #1898 from microsoft/vnext
irvinesunday Oct 29, 2024
18482f3
Merge pull request #1906 from microsoft/vnext
MaggieKimani1 Nov 6, 2024
d7b19ce
Merge pull request #1908 from microsoft/vnext
MaggieKimani1 Nov 7, 2024
df5d0c7
Merge pull request #1914 from microsoft/vnext
MaggieKimani1 Nov 12, 2024
55352f1
ci: updates main with the latest ci changes
baywet Dec 19, 2024
a3c6c83
fix: removes extraneous download artifact task
baywet Dec 19, 2024
662e9d7
fix: hidi GH release
baywet Dec 19, 2024
1ae06b1
fix: redundant artifact upload
baywet Dec 19, 2024
e521230
Merge pull request #2005 from microsoft/ci/updates-to-main
baywet Dec 19, 2024
166747f
fix: removes actions steps that create extraneous tags
baywet Dec 20, 2024
ff52d83
fix: updates output syntax for tag version
baywet Dec 20, 2024
2fcda79
ci: moves create github release to its own job
baywet Dec 20, 2024
ee99c4d
nit: fixes indent
baywet Dec 20, 2024
2efd4eb
Merge pull request #2017 from microsoft/fix/ci-hidi-gh-upload-to-main
baywet Dec 20, 2024
c3d0c15
Merge pull request #2015 from microsoft/dev
baywet Dec 20, 2024
e7dfa1a
fix: reverts to a regular variable for the tag value
baywet Dec 20, 2024
5a824bb
ci: fix artefacts path
baywet Dec 20, 2024
249ff45
Merge pull request #2021 from microsoft/fix/ci-tag-value-to-main
baywet Dec 20, 2024
cce2495
Merge pull request #2028 from microsoft/dev
baywet Dec 24, 2024
45329e4
fix: adds missing culture argument to date serialization
baywet Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Collections.Generic;
using System.Globalization;
using System.IO;
using System.Linq;
using System.Text.Json;
Expand Down Expand Up @@ -188,7 +189,7 @@ public virtual void WriteValue(long value)
/// <param name="value">The DateTime value.</param>
public virtual void WriteValue(DateTime value)
{
this.WriteValue(value.ToString("o"));
this.WriteValue(value.ToString("o", CultureInfo.InvariantCulture));
}

/// <summary>
Expand All @@ -197,7 +198,7 @@ public virtual void WriteValue(DateTime value)
/// <param name="value">The DateTimeOffset value.</param>
public virtual void WriteValue(DateTimeOffset value)
{
this.WriteValue(value.ToString("o"));
this.WriteValue(value.ToString("o", CultureInfo.InvariantCulture));
}

/// <summary>
Expand Down
Loading