Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for handling unrecognized keywords #1982

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Add support for handling unrecognized keywords #1982

merged 10 commits into from
Dec 19, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1970

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2024
View reviewed changes
src/Microsoft.OpenApi/Models/OpenApiSchema.cs
@@ -403,6 +408,7 @@
UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
Reference = schema?.Reference != null ? new(schema?.Reference) : null;
Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
MaggieKimani1 and others added 3 commits December 11, 2024 17:49
@MaggieKimani1
Reduce redundancy and use LINQ statement
f27415d
@baywet
chore: uses backing fields
09158e2 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
chore: code linting
7d297be 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet self-requested a review as a code owner December 19, 2024 12:17
@baywet baywet enabled auto-merge December 19, 2024 12:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 19, 2024
View reviewed changes
src/Microsoft.OpenApi/Models/OpenApiSchema.cs
@@ -373,7 +362,7 @@
MinLength = schema?.MinLength ?? MinLength;
Pattern = schema?.Pattern ?? Pattern;
MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
src/Microsoft.OpenApi/Models/OpenApiSchema.cs
@@ -392,8 +381,8 @@
AdditionalPropertiesAllowed = schema?.AdditionalPropertiesAllowed ?? AdditionalPropertiesAllowed;
AdditionalProperties = schema?.AdditionalProperties != null ? new(schema?.AdditionalProperties) : null;
Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null;
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
src/Microsoft.OpenApi/Models/OpenApiSchema.cs
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
@baywet baywet merged commit 8bf3fbe into vnext Dec 19, 2024
7 checks passed
@baywet baywet deleted the mk/support-unrecognized-keywords branch December 19, 2024 12:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ooprala pushed a commit to VitaliyKurokhtin/OpenAPI.NET that referenced this pull request Feb 4, 2025
Backport support for Schema unrecognized keywords from microsoft#1982
a4cb71d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Review] : Implement support for handling unrecognized keywords in the OpenAPISchema
2 participants
@MaggieKimani1 @baywet