Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse server's url with variables when convert openapi spec 3.0 to 2.0 #1293

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

TinaLiu02
Copy link
Contributor

@TinaLiu02 TinaLiu02 commented Jul 18, 2023

Applied the suggested changes and the test results as below.
OpenAPI Workbench: The URL in server object supports Server Variables in 3.0, now it has been converted to 2.0 correctly. Please refer below screenshot.
image

Unit Test Results:
image

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, here is a suggestion

src/Microsoft.OpenApi/Models/OpenApiDocument.cs Outdated Show resolved Hide resolved
Co-authored-by: Vincent Biret <vincentbiret@hotmail.com>
@TinaLiu02
Copy link
Contributor Author

Thanks. Applied the suggested changes.

@TinaLiu02 TinaLiu02 requested a review from baywet July 19, 2023 01:24
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! @MaggieKimani1 and @millicentachieng to review and merge

@MaggieKimani1 MaggieKimani1 merged commit da71361 into microsoft:vnext Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants