Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Deep copying of objects implementing the dictionary type using copy constructors #1203

Merged
merged 19 commits into from
Apr 11, 2023
Merged

Fix Deep copying of objects implementing the dictionary type using copy constructors #1203

merged 19 commits into from
Apr 11, 2023

Conversation

MaggieKimani1
Copy link
Contributor

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 6, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

MaggieKimani1 and others added 2 commits April 6, 2023 16:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

baywet
baywet approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

@MaggieKimani1 MaggieKimani1 merged commit 97e1a24 into vnext Apr 11, 2023
@MaggieKimani1 MaggieKimani1 deleted the is/copy-ctrs branch April 11, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy constructor doesn't create new OpenApiPathItem objects when creating new instance of OpenApiPaths
3 participants
@MaggieKimani1 @baywet @irvinesunday