Adds action/function suffix to tag names for action/function operations #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update operation tags generation * Refactor operation tag generation * Update unit tests * Update integration test files * Update release note * Update src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com> * Account for nullability * Remove unnecessary code --------- Co-authored-by: Andrew Omondi <andrueastman@users.noreply.github.com>
baywet
requested changes
Jan 17, 2025
| @@ -21,8 +21,13 @@ | |||
| <PackageTags>Microsoft OpenApi OData EDM</PackageTags> | |||
| <RepositoryUrl>https://github.com/Microsoft/OpenAPI.NET.OData</RepositoryUrl> | |||
| <PackageReleaseNotes> | |||
| - Further fix for generating unique operation ids for navigation property paths with composable overloaded functions #596 | |||
| </PackageReleaseNotes> | |||
| - Upgraded to Microsoft.Odata.Edm 8.0.0 | |||
There was a problem hiding this comment.
those are changelogs from v2, I believe something went wrong in your cherry-pick, you should revert this and add an entry specific to your change + version bump
| // ODataNavigationSourceSegment | ||
| // If the operation is a function or action, append the word "Function" or "Action" to the tag name | ||
| case ODataOperationSegment operationSegment: | ||
| tagName = NavigationSource.Name + "." + NavigationSource.EntityType.Name; |
There was a problem hiding this comment.
Suggested change
| tagName = NavigationSource.Name + "." + NavigationSource.EntityType.Name; | |
| tagName = NavigationSource.Name + "." + NavigationSource.EntityType().Name; |
(and other places)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640
Cherry picks from #586 and adds "Actions" or "Functions" as suffixes to the tag. This will
enable the powershell mappings to be updated to target the paths more precisely to fix the incorrect mappings.
enable the user functions/actions to still remain in their current modules by targeting operationIds like user.*.Actions.