Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for targetedMobileApps #5509

Merged

Conversation

dannyKBjj
Copy link
Contributor

Reviewed documentation on appListItem resource type for targetedMobileApps property and realised one of the properties was not correctly defined in the schema.mof. Corrected mof, psm1 and unit test scripts.

https://learn.microsoft.com/en-us/graph/api/resources/intune-deviceconfig-applistitem?view=graph-rest-beta

Pull Request (PR) description

Reviewed documentation on appListItem resource type for targetedMobileApps property and realised one of the properties was not correctly defined in the schema.mof. Corrected mof, psm1 and unit test scripts.

Not updated change log as IntuneVPNConfigurationPolicyIOS is still in # UNRELEASED / initial release.

https://learn.microsoft.com/en-us/graph/api/resources/intune-deviceconfig-applistitem?view=graph-rest-beta

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

Reviewed documentation on appListItem resource type for targetedMobileApps property and realised one of the properties was not correctly defined in the schema.mof. Corrected mof, psm1 and unit test scripts.

https://learn.microsoft.com/en-us/graph/api/resources/intune-deviceconfig-applistitem?view=graph-rest-beta
@dannyKBjj
Copy link
Contributor Author

don't believe targetedMobileApps is even available through Intune GUI, so functionality probably not affected.

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 8a79f80 into microsoft:Dev Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants