Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AuthenticationFlows in Conditional Access Policy #4970

Merged

Conversation

FabienTschanz
Copy link
Contributor

Pull Request (PR) description

This Pull Request addresses an issue where the AuthenticationFlows property of a conditional access policy changed in Graph, thus leading to an incorrect provisioning of TransferMethods in the AADConditionalAccessPolicy resource.

The new definition of AuthenticationFlows is the following:

  • $null if no transfer method is specified
  • @{ transferMethods = '<value>' } if a transfer method is specified

Since one or two values can be used, separated by a comma, an additional check in Test-TargetResource was introduced, which checkes that if two values are specified, they can be written in any order.

To preserve backwards compatibility since TransferMethods doesn't have to be specified (while in newer exports it is always done by default), the property is only checked in Test-TargetResource if it is contained in PSBoundParameters. Otherwise, it will be ignored.

This Pull Request (PR) fixes the following issues

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 00a79f9 into microsoft:Dev Aug 21, 2024
2 checks passed
@FabienTschanz FabienTschanz deleted the fix/conditional-access-transfermethods branch August 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants