Several resources: Correctly remove trailing commas and semi colons between items of an array of CIM instances added by Convert-DSCStringParamToVariable

[ricmestre]

Pull Request (PR) description

Correctly remove trailing commas and semi colons between items of an array of CIM instances added by Convert-DSCStringParamToVariable.

Chunk of code added to all resources that call Convert-DSCStringParamToVariable and that at least one of those calls has an object with an array of CIM instances (or may have depending on the exported resource).

This Pull Request (PR) fixes the following issues

• Fixes Issues exporting with several resources in Intune that have embedded instances #3335
• Superseeds PR: Fixes 3335 #3362

[NikCharlebois]

Wouldn't it be a better idea to modify the ConvertTo-DSCStringParamToVariable method instead of addressing it individually in every resource? We should look at updating ReverseDSC instead.

[ricmestre]

@NikCharlebois hello regardless of how it's done I need to get this solved ASAP since I'm soon to get this into production, let me know where I can can change and I'll send a new PR. I really need this solved!

[ricmestre]

@NikCharlebois Hi, just raised PR microsoft/ReverseDSC#33 to solve this issue, as mentioned there if that fix goes in then #3362 and #3364 can be closed. After that all DSC resources that still have that chunk of code can have it removed since it won't be required any longer.

[ricmestre]

Issue should be resolved directly in ReverseDSC and conversation about this is already on going on microsoft/ReverseDSC#33 therefore this PR can be closed.