Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures no resource instance have the same name when extracting them. #3184

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Ensures no resource instance have the same name when extracting them. #3184

merged 3 commits into from
Apr 19, 2023

Conversation

NikCharlebois
Copy link
Collaborator

Pull Request (PR) description

  • Fixes an issue where the new resource name extraction could still have duplicates.

This Pull Request (PR) fixes the following issues

  • N/A

ykuijs
ykuijs approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykuijs ykuijs merged commit 5d890f3 into microsoft:Dev Apr 19, 2023
@NikCharlebois NikCharlebois deleted the FixForNameExtraction branch April 19, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikCharlebois @ykuijs