Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSFT_IntuneAppProtectionPolicyiOS.psm1 - fixes #2942 #2988

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

menswearUK
Copy link
Contributor

apologies - original PR failed when I tried to resolve conflicts - I cleared commits and it auto merged nothing - this contains the changes previously present in that PR

Pull Request (PR) description

Changes to New-M365DSCConnection function to address beta msgraph profile not being applied correctly

This Pull Request (PR) fixes the following issues

fixes #2942

original PR failed when I tried to resolve conflicts, merged nothing - this contains the changes present in that PR
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small last request

CHANGELOG.md Outdated
@@ -26,6 +26,8 @@
actually exist.
* Added application credential support to Assert-M365DSCBlueprint
FIXES [#1792](https://github.com/microsoft/Microsoft365DSC/pull/1792)
* Added checks in New-M365DSCConnection to ensure beta MSGraph profile is correctly set when requested
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this under an UNRELEASED section at the top of the file. You now added it to the v1.23.308.1 release that was released today and this PR is not part of that release.

@menswearUK
Copy link
Contributor Author

@ykuijs no worries, I've amended that now. once again, sorry for messing up the previous PR

@ykuijs
Copy link
Member

ykuijs commented Mar 9, 2023

No problem, thanks for your help fixing this issue!!

Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntuneAppProtectionPolicyIOS - Test-TargetResource returns false even if config matches existing policy
2 participants