-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues discussed in #2786 #2794
Conversation
An additional commit is required, Export-TargetResource doesn't work. Please wait. |
Export-TargetResource still not fully working |
I've submitted a PR for ReverseDSC as I had issues getting rid of commas between CimInstances in arrays when exporting resources.. That PR should be approved before this one |
rebased, update should be OK now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Export breaks now - not yet sure why |
I recently updated the unit tests to specifically check if output is returned. So the code should always return a value. If the code is hitting an exception and therefore jumping into the catch block, it returns an empty string. This will trigger the test to fail. To troubleshoot: Open the test file and place a breakpoint on the line where the export is ran. Than execute the test and step through the code. You can see where the code fails and jumps into the catch block. When you then run $_, you can see what the error is that is being generated. |
@ykuijs, thanks a lot ! I've never thought to run tests like that but it was invaluable in this case. |
Ahhhh, that small 's' has been a pain in the b*tt on my end as well while updating all unit tests. That mistake was made on multiple locations. I just started the unit tests and will merge it once they complete. Thanks a lot for all your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request (PR) description
This PR implements several fixes to the DSC-resource AADAdministrativeUnit
The resource has been updated to only use the v1.0 Graph-profile
Note that the schema and parameters are slightly changed with respect to parameter ScopedRoleMembers in order to avoid nested CimInstances. However, the current resource is broken and has never worked so this isn't really a BR. Please see #2786
This Pull Request (PR) fixes the following issues