Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODSettings][SPOSharingSettings]: Constant Drifts Detected #4979

Closed
abhisri13 opened this issue Aug 21, 2024 · 2 comments · Fixed by #5336 or #5346
Closed

[ODSettings][SPOSharingSettings]: Constant Drifts Detected #4979

abhisri13 opened this issue Aug 21, 2024 · 2 comments · Fixed by #5336 or #5346

Comments

@abhisri13
Copy link

Description of the issue

DSC is constantly detecting and reporting drift with parameters related to external users accepting external sharing invitations most likely indicating towards a backend deprecation scenario of parameters.

Resource Drift Parameter
SPOSharingSettings RequireAcceptingAccountMatchInvitedAccount
ODSettings NotifyOwnersWhenInvitationsAccepted

Both of these parameters are set to TRUE in our DSC config but drift reporting suggests it to be set as FALSE constantly and we have validated that it's not a true drift.
This issue suggest that it could be deprecated: cisagov/ScubaGear#1267 but no related change has been reported in the latest DSC releases.

Microsoft 365 DSC Version

1.24.731.1

Which workloads are affected

OneDrive for Business, SharePoint Online

The DSC configuration

ODSettings 'OD SETTINGS' {
        IsSingleInstance                          = 'Yes'
        BlockMacSync                              = $false;
        DisableReportProblemDialog                = $true;
        DomainGuids                               = @();
        NotificationsInOneDriveForBusinessEnabled = $false;
        NotifyOwnersWhenInvitationsAccepted       = $true;
        ODBAccessRequests                         = "Unspecified";
        ODBMembersCanShare                        = "Unspecified";
        OneDriveForGuestsEnabled                  = $false;
        OneDriveStorageQuota                      = 12345;
        OrphanedPersonalSitesRetentionPeriod      = 900;
        GrooveBlockOption                         = "OptOut";
        ExcludedFileExtensions                    = @('abcd');
        Ensure                                    = 'Present';
        ApplicationId                             = $ApplicationId;
        TenantId                                  = $TenantId;
        CertificateThumbprint                     = $Thumbprint;
    }
}



SPOSharingSettings 'SPO SHARING SETTINGS' {
        IsSingleInstance                           = 'Yes'
        SharingCapability                          = 'ExistingExternalUserSharingOnly'
        MySiteSharingCapability                    = 'Disabled'
        ShowEveryoneClaim                          = $false
        ShowAllUsersClaim                          = $false
        ShowEveryoneExceptExternalUsersClaim       = $true
        ProvisionSharedWithEveryoneFolder          = $false
        EnableGuestSignInAcceleration              = $false
        BccExternalSharingInvitations              = $false
        SharingDomainRestrictionMode               = 'None'
        DefaultSharingLinkType                     = 'Direct'
        PreventExternalUsersFromResharing          = $true
        ShowPeoplePickerSuggestionsForGuestUsers   = $false
        NotifyOwnersWhenItemsReshared              = $true
        DefaultLinkPermission                      = 'View'
        RequireAcceptingAccountMatchInvitedAccount = $true
        Ensure                                     = 'Present'
        ApplicationId                              = $ApplicationId
        TenantId                                   = $TenantId
        CertificateThumbprint                      = $Thumbprint
}

Verbose logs showing the problem

<ConfigurationDrift Source="MSFT_SPOSharingSettings" TenantId="contoso.com">
        <ParametersNotInDesiredState>
            <Param Name="RequireAcceptingAccountMatchInvitedAccount"><CurrentValue>False</CurrentValue><DesiredValue>True</DesiredValue></Param>
        </ParametersNotInDesiredState>
    </ConfigurationDrift>



<ConfigurationDrift Source="MSFT_ODSettings" TenantId="contoso.com">
        <ParametersNotInDesiredState>
            <Param Name="NotifyOwnersWhenInvitationsAccepted"><CurrentValue>False</CurrentValue><DesiredValue>True</DesiredValue></Param>
        </ParametersNotInDesiredState>
    </ConfigurationDrift>

Environment Information + PowerShell Version

OsName               : Microsoft Windows Server 2022 Datacenter
OsOperatingSystemSKU : DatacenterServerEdition
OsArchitecture       : 64-bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 20348.1.amd64fre.fe_release.210507-1500
OsLanguage           : en-US
OsMuiLanguages       : {en-US}



Name                           Value
----                           -----
PSVersion                      5.1.20348.2652
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.20348.2652
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
@ssoabx
Copy link
Contributor

ssoabx commented Oct 1, 2024

@NikCharlebois
Copy link
Collaborator

Both parameters are deprecated and do not have any effect on the tenant. We will update both resource to ensure the Test-TargetResource doesn't threat them as drifts.

E.g.,For SPOSharingSettings:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants