-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] [ci] Use manylinux image to produce wheels #5514
Comments
Now that CI is working again, next I'm going to prioritize this issue, based on the discussion in #5390 (comment), so that we can upgrade to I'll work on an image on the |
Did some research tonight, and I think we should pursue It's a big jump (
Reasons to prefer
|
library | manylinux1 | manylinux_2010 | manylinux2014 | manylinux_2_17 |
---|---|---|---|---|
catboost (link) |
✅ | |||
numpy (link) |
✅ | ✅ | ||
scikit-learn (link) |
✅ | ✅ | ||
xgboost (link) |
✅ | ✅ |
Summary
Created from #5390 (comment).
The following changes should be made in LightGBM:
GLIBC >= 2.14
toGLIBC >= 2.23
manylinux
images (https://github.com/pypa/manylinux)Motivation
It has been really difficult to maintain support for older operating systems and versions of GLIBC.
References:
Moving to newer base image and higher floor for GLIBC and supported Ubuntu version should help to alleviate some maintenance burden.
Description
As described in #5390 (comment), LightGBM should upgrade to a
manylinux
base image supporting at leastGLIBC==2.23
(and not too much higher) for producing wheels.The
manylinux
README shows the following compatibility for wheels produced on those images (https://github.com/pypa/manylinux).https://ubuntu.com/about/release-cycle describes the release cycle for versions of Ubuntu
Using an approach like the following
docker run \ --rm \ --entrypoint="" \ -it quay.io/pypa/manylinux1_x86_64 \ ldd --version
I found that the GLIBC version for the published
manylinux
images is as follows.References
Other related conversations:
manylinux_2010
: Add arm64 wheel to travis-ci #3421 (comment)manylinux_x_y
tags eventually: Python wheels not PEP 599 compliant; wheels should include libgomp.so.1 #4484 (comment)lightgbm
's x86_64 wheel being labeledmanylinux1
even though it is not fully compatible with that tag: [python-package] LightGBM wheel on PyPI seems to have the wrong platform tag #4788The text was updated successfully, but these errors were encountered: