Fix integer overflow in auc_mu. (#3209)

microsoft · Jul 7, 2020 · 1e2013a · 1e2013a
1 parent d8bc0fc
commit 1e2013a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/metric/multiclass_metric.hpp b/src/metric/multiclass_metric.hpp
@@ -286,10 +286,10 @@ class AucMuMetric : public Metric {
     double ans = 0;
     for (int i = 0; i < num_class_; ++i) {
       for (int j = i + 1; j < num_class_; ++j) {
-        ans += S[i][j] / (class_sizes[i] * class_sizes[j]);
+        ans += (S[i][j] / class_sizes[i]) / class_sizes[j];
       }
     }
-    ans = 2 * ans / (num_class_ * (num_class_ - 1));
+    ans = (2 * ans / num_class_) / (num_class_ - 1);
     return std::vector<double>(1, ans);
   }