Protect against overloaded operator& #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect against overloaded operator&.
… Using decay for C arrays instead.
|
@LYP951018, I was wondering if you could add some unit tests that demonstrate an overloaded |
|
I'm curious of a valid use for overloading operator& and how this should behave in that situation. Obviously you could write a bad operator& that would do the wrong thing and write a unit test against it, but op& isn't a very common thing to override so we should make sure we're understanding that use case and not breaking it before making a change that cannot be undone without breaking existing users. |
|
@neilmacintosh Unit tests have been added. |
neilmacintosh
pushed a commit
that referenced
this pull request
Aug 20, 2018
* Changed &arr[0] to std::array<T, N>::data and std::address_of to protect against overloaded operator&. * Removed the usage of `std::addressof` because it is a C++ 17 feature. Using decay for C arrays instead. * Add unit tests for #662. * Added c++17 test configurations for clang5.0 and clang6.0 * fixed CppCoreCheck pointer decay warning
|
Thanks @LYP951018, your change is included #723, appreciate your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #661 .