-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presence-tracker): Add "reactions" using presence notifications #23294
base: main
Are you sure you want to change the base?
feat(presence-tracker): Add "reactions" using presence notifications #23294
Conversation
…esence-tracker-notifications
…esence-tracker-notifications
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small things, otherwise LGTM. Disclaimer: I might not be the target audience you were interested in for a "new eyes" review, I've dealt a bit with the presence framework before for the ai-collab example app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix was merged and released yesterday, no more need for a patch 🥳
// In the future, we'll be able to use IMousePosition here. | ||
position: { x: number; y: number }, | ||
value: string, | ||
intensity: "normal" | "intense", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to exercise the "intense" case? If not I'd say remove it to keep things simple.
Summary of changes
The presence-tracker example now uses the notifications infrastructure from the presence package to send "reactions" to other clients. Users can select any emoji from an emoji picker, and any left click in the window will send the reaction to other users. Other clients will see the reaction animate and fade out.
Implementation notes
Known issues