-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build-tools): Update build-tools to use common build-infra #22657
Draft
tylerbutler
wants to merge
64
commits into
microsoft:main
Choose a base branch
from
tylerbutler:bt-build-infra-build-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(build-tools): Update build-tools to use common build-infra #22657
tylerbutler
wants to merge
64
commits into
microsoft:main
from
tylerbutler:bt-build-infra-build-tools
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
PRs targeted against main branch
area: build
Build related issues
area: contributor experience
area: examples
Changes that focus on our examples
dependencies
Pull requests that update a dependency file
public api change
Changes to a public API
labels
Sep 27, 2024
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 880afad |
tylerbutler
force-pushed
the
bt-build-infra-build-tools
branch
from
October 9, 2024 19:39
a7cae1a
to
6e8541c
Compare
github-actions
bot
removed
area: contributor experience
changeset-present
area: examples
Changes that focus on our examples
dependencies
Pull requests that update a dependency file
labels
Oct 9, 2024
tylerbutler
force-pushed
the
bt-build-infra-build-tools
branch
from
November 1, 2024 21:10
5f1e473
to
9419256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: build
Build related issues
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Read the PR description for #22347 first. This change builds on top of that infrastructure.
In #22347 we introduced a new package with common infrastructure for build-cli and fluid-build. This change is the first step in adapting those packages to the new infrastructure.
Summary of changes
fluid-build (build-tools)
IFluidBuildPackageJson
extendsPackageJson
with fluid-build-specific config properties. This type is used as the package.json type through fluid-build.IFluidBuildPackage
extendsIPackage<IFluidBuildPackageJson>
and is intended to be a replacement for the currently exportedPackage
class.Package
class has been updated to useIPackage
wherever possible, andIFluidBuildPackage
in places that need fluid-build specific properties.Package
class was renamed toPackageClass
and its load functions are marked deprecated. There are still uses in build-cli, so the class remains exported.IFluidBuildPackage
is exported asPackage
so most downstream code does not need to be updated. However, there are places where the PackageClass is used directly that will be cleaned up in a future change.IFluidBuildPackageJson
is exported from the package asPackageJson
for the same reasons as above. Once build-cli is more fully converted to use build-infrastructure, then these uses will be removed and the exports can also be removed.build-cli
Package
class as a type narrower, butPackage
is now an interface (see above). In all those cases I was able to rewrite the logic to narrow the types differently. This was done to minimize churn in this change.PackageClass
is still used in the flub filtering and selection code. That code can mostly be deleted once it's using build-infrastructure, because that package includes the filtering support directly in the IFluidRepo type.