Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(build-tools): Upgrade oclif dependencies #20908

Merged
merged 12 commits into from
May 3, 2024

Conversation

tylerbutler
Copy link
Member

@tylerbutler tylerbutler commented Apr 29, 2024

Upgrades oclif-related dependencies to the latest version. The most important upgrade is to @oclif/test, which was a major version behind latest because of a test issue that was addressed in the latest patch.

@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Apr 29, 2024
@tylerbutler tylerbutler changed the title build(build-tools): Bump @oclif/test to latest build(build-tools): Upgrade oclif dependencies May 3, 2024
@tylerbutler tylerbutler marked this pull request as ready for review May 3, 2024 01:16
@tylerbutler tylerbutler requested a review from a team May 3, 2024 02:36
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about dep changes, but can't say they have to be addressed.

@@ -1565,7 +1924,7 @@ packages:
- typescript
dev: true

/@fluid-tools/build-cli/0.29.0_typescript@5.1.6:
/@fluid-tools/build-cli/0.29.0_lazgpcpm5xssvy6zj7dsqbusoe:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is going to a hash and not longer a named distinguisher?

Comment on lines 12443 to 12449
/yarn/1.22.22:
resolution: {integrity: sha512-prL3kGtyG7o9Z9Sv8IPfBNrWTDmXB4Qbes8A9rEzt6wkJV8mUvoirjU0Mp3GGAU06Y0XQyA3/2/RQFVuK7MTfg==}
engines: {node: '>=4.0.0'}
hasBin: true
requiresBuild: true
dev: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something now pulls in yarn? For what?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new patch of @oclif/plugins-plugins

image

From a previous patch. Seems reasonable based on what oclif is...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the default oclif setup, but we don't currently use it. I'll remove the dep and the config in package.json. We can always add it back if we want to use the feature later.

@@ -710,6 +711,53 @@ packages:
transitivePeerDependencies:
- aws-crt

/@aws-sdk/client-sso-oidc/3.568.0_f5hjed2pgq3vcatdx6pdivrwea:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no good deduplication with these big non-dev aws additions?

@tylerbutler tylerbutler enabled auto-merge (squash) May 3, 2024 16:33
@tylerbutler tylerbutler merged commit 618d3c6 into microsoft:main May 3, 2024
29 checks passed
@tylerbutler tylerbutler deleted the bt-upgrade-oclif-test branch May 3, 2024 16:37
'@smithy/protocol-http': 3.3.0
'@smithy/types': 2.12.0
tslib: 2.6.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see @aws-sdk duplication like this. Were recent changes meant to address these cases? Should we have any @aws-sdk in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants