-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flags endpoint support #524
base: main
Are you sure you want to change the base?
Add feature flags endpoint support #524
Conversation
… for FeatureFlagsEndpointFilterExtensions
@microsoft-github-policy-service agree |
@crodriguesbr Thank you for contributing to the feature management repo! This PR is related to #253 |
src/Microsoft.FeatureManagement.AspNetCore/FeatureFlagsEndpointFilterExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
src/Microsoft.FeatureManagement.AspNetCore/FeatureFlagsEndpointFilterExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.FeatureManagement.AspNetCore/FeatureFlagsEndpointFilterExtensions.cs
Outdated
Show resolved
Hide resolved
Hi, @crodriguesbr My team have reviewed this PR. We generally agree with the code implementation. This is a new cool feature. Thank you so much for sending out this PR. ❤️ Except for the comment I left, there are still some nits or code style issues about this PR. We do have linting rules in the .editorconfig file but the rule set is used by all of our C# code base. So we only keep the “greates common divisor`. There are some code style conventions which is specific to this repo. We do want our code bases to be consistent and looks like written by one person. Would you mind if I take over this PR to address the code style issues? If no, I can left comments for those issues. |
BTW, could you also update the PR description as the example usage has changed. @crodriguesbr |
Done! |
Hi, @zhiyuanliang-ms Thank you for your kind words about this PR! I'm happy your team finds this helpful feature. Regarding the code style issues, I completely understand the importance of keeping the codebase consistent. I'd prefer to address these issues myself, as it would help me better understand your conventions for future contributions. If you could leave comments outlining the needed changes, I'd happily adjust them. Looking forward to your feedback! Best regards, |
Why this PR?
Visible Changes
Example usage:
endpoints.MapGet("/api/feature", () => "Feature Enabled") . WithFeatureGate("MyFeature");