-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds extension methods for TrackEvent and TrackMetric #348
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a42c2c
Adds extension methods for TrackEvent and TrackMetric
rossgrambo f9c3064
Adds copyright, crefs, and uses []= instead of .Add for properties
rossgrambo c76dba5
Update src/Microsoft.FeatureManagement.Telemetry.ApplicationInsights/…
rossgrambo 8560fb9
Added null check, moved shared logic to helper functions
rossgrambo 0168adf
Removed TrackMetric extension for now
rossgrambo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
75 changes: 75 additions & 0 deletions
75
...FeatureManagement.Telemetry.ApplicationInsights/ApplicationInsightsTelemetryExtensions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT license. | ||
// | ||
using Microsoft.ApplicationInsights; | ||
using Microsoft.ApplicationInsights.DataContracts; | ||
using Microsoft.FeatureManagement.FeatureFilters; | ||
|
||
namespace Microsoft.FeatureManagement.Telemetry.ApplicationInsights | ||
{ | ||
/// <summary> | ||
/// Provides extension methods for tracking events with TargetingContext. | ||
/// </summary> | ||
public static class ApplicationInsightsTelemetryExtensions | ||
rossgrambo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
/// <summary> | ||
/// Extension method to track an event with <see cref="TargetingContext"/>. | ||
/// </summary> | ||
public static void TrackEvent(this TelemetryClient telemetryClient, string eventName, TargetingContext targetingContext, IDictionary<string, string> properties = null, IDictionary<string, double> metrics = null) | ||
{ | ||
if (properties == null) | ||
{ | ||
properties = new Dictionary<string, string>(); | ||
} | ||
|
||
properties["TargetingId"] = targetingContext.UserId; | ||
|
||
telemetryClient.TrackEvent(eventName, properties, metrics); | ||
} | ||
|
||
/// <summary> | ||
/// Extension method to track an <see cref="EventTelemetry"/> with <see cref="TargetingContext"/>. | ||
/// </summary> | ||
public static void TrackEvent(this TelemetryClient telemetryClient, EventTelemetry telemetry, TargetingContext targetingContext) | ||
{ | ||
if (telemetry == null) | ||
rossgrambo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
telemetry = new EventTelemetry(); | ||
} | ||
|
||
telemetry.Properties["TargetingId"] = targetingContext.UserId; | ||
rossgrambo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
telemetryClient.TrackEvent(telemetry); | ||
} | ||
|
||
/// <summary> | ||
/// Extension method to track a metric with <see cref="TargetingContext"/>. | ||
/// </summary> | ||
public static void TrackMetric(this TelemetryClient telemetryClient, string name, double value, TargetingContext targetingContext, IDictionary<string, string> properties = null) | ||
rossgrambo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
if (properties == null) | ||
{ | ||
properties = new Dictionary<string, string>(); | ||
} | ||
|
||
properties["TargetingId"] = targetingContext.UserId; | ||
|
||
telemetryClient.TrackMetric(name, value, properties); | ||
} | ||
|
||
/// <summary> | ||
/// Extension method to track a <see cref="MetricTelemetry"/> with <see cref="TargetingContext"/>. | ||
/// </summary> | ||
public static void TrackMetric(this TelemetryClient telemetryClient, MetricTelemetry telemetry, TargetingContext targetingContext) | ||
{ | ||
if (telemetry == null) | ||
{ | ||
telemetry = new MetricTelemetry(); | ||
} | ||
|
||
telemetry.Properties["TargetingId"] = targetingContext.UserId; | ||
|
||
telemetryClient.TrackMetric(telemetry); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same suggestion for other occurrences of the word "TargetingContext"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #347 (comment)
I understand we will use
TargetingContext
instead ofITargetingContext
here. But I am wondering why we useITargetingContext
forContextualTargetingFilter
. It seems likeContextualTargetingFilter
is the only place we useITargetingContext
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contextual filters describe an interface that they handle. This allows a single app context type to satisfy multiple contextual feature filters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Removing my comment in favor of Jimmy's ^