prevent the usage of colon in feature flag name

microsoft · Oct 18, 2023 · 0325751 · 0325751
1 parent 17d6202
commit 0325751
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs b/src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs
@@ -56,6 +56,11 @@ public Task<FeatureDefinition> GetFeatureDefinitionAsync(string featureName)
                 throw new ArgumentNullException(nameof(featureName));
             }
 
+            if (featureName.Contains(ConfigurationPath.KeyDelimiter))
+            {
+                throw new ArgumentException($"The value '{ConfigurationPath.KeyDelimiter}' is not allowed in the feature name.", nameof(featureName));
+            }
+
             if (Interlocked.Exchange(ref _stale, 0) != 0)
             {
                 _definitions.Clear();