Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load XML from EventLogReader #310

Merged
merged 5 commits into from
Feb 8, 2024
Merged

Load XML from EventLogReader #310

merged 5 commits into from
Feb 8, 2024

Conversation

bill-long
Copy link
Member

@bill-long bill-long commented Feb 8, 2024

With this change, we load the XML from the EventLogReader by calling ToXml() on the EventRecord, rather than generating our own XML from the Properties collection.

Pros:

  • Full-fidelity XML instead of the partial XML we had before.

Cons:

  • Loading the XML this way takes time. We do this in the background after the initial load, and the status is reflected in the status bar. Note the user can navigate to events and see XML immediately (we resolve it when they click on the event) even when this job is in progress.
  • Storing these big XML strings take memory. With a set of 4 logs that caused EventLogExpert to use about 7 GB of memory before this change, we now use about 10.5 GB of memory for the same logs.

Fixes #256

@bill-long bill-long requested a review from a team as a code owner February 8, 2024 17:40
We can free the memory by just nulling it out and let the
finalizer deal with disposal. Disposing breaks our tests.
@jschick04 jschick04 merged commit 4d2be46 into main Feb 8, 2024
2 checks passed
@jschick04 jschick04 deleted the bilong-xmllazyload branch February 8, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues parsing CAPI2 event logs
2 participants