Refactored FilterModel and FilterRow #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent to utilize the dynamic value
1ca8b58 to
b95cba5
Compare
bill-long
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted FilterValue to use dynamic type and added FilterSelect component to handle this change.
Refactored FilterRow to handle this dynamic type and fixed an issue with filters not clearing when the Value is changed back to a "reset" value.
Also set the main filter to disable the drop down if there is a sub filter to prevent any exceptions. Could change this later to just remove all sub filters anytime the column to "filter on" changes.