Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Preview Hashing sentinel value to dxil validator #7053

Merged
merged 15 commits into from
Jan 25, 2025
Merged

Add Preview Hashing sentinel value to dxil validator #7053

merged 15 commits into from
Jan 25, 2025
+250 −23

Conversation

bob80905
Copy link
Collaborator

@bob80905 bob80905 commented Jan 9, 2025 •
edited
Loading

When the dxil validator detects that the target shader model is a preview shader model that hasn't officially been released, it should sign the dxil container with a special sentinel hash: 02020202020202020202020202020202

Fixes #7083

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

✅ With the latest revision this PR passed the Python code formatter.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@bob80905 bob80905 changed the title Add Preview Hashing sentinal value to dxil validator Add Preview Hashing sentinel value to dxil validator Jan 9, 2025
@bob80905 bob80905 marked this pull request as ready for review January 23, 2025 01:37
@bob80905 bob80905 requested a review from a team as a code owner January 23, 2025 01:37
tex3d
tex3d reviewed Jan 23, 2025
View reviewed changes
utils/hct/hctdb_instrhelp.py Outdated Show resolved Hide resolved
tex3d
tex3d reviewed Jan 23, 2025
View reviewed changes
utils/hct/hctdb_instrhelp.py Outdated Show resolved Hide resolved
tex3d
tex3d requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prior comments.

@bob80905 bob80905 force-pushed the addPreviewHashSigning branch from 1776d9f to dafab82 Compare January 23, 2025 20:09
tex3d
tex3d approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

llvm-beanz
llvm-beanz approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some coding style nits, feel free to ignore them. I know DXC's added code doesn't really conform with LLVM Coding Standards, but I do think consistency in how we write new code is nice.

Overall I think this change looks good.

lib/DXIL/DxilShaderModel.cpp Outdated Show resolved Hide resolved
lib/DXIL/DxilShaderModel.cpp Outdated Show resolved Hide resolved
lib/DxilValidation/DxilContainerValidation.cpp Outdated Show resolved Hide resolved
@bob80905 bob80905 merged commit 10b3328 into microsoft:main Jan 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llvm-beanz llvm-beanz llvm-beanz approved these changes

@tex3d tex3d tex3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Validator] Enable Preview ByPass Hash
3 participants
@bob80905 @tex3d @llvm-beanz