Make marshalling 'System.Type' AOT-safe #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regresses size by 1 KB, but it makes
|
manodasanW
reviewed
Jan 22, 2024
manodasanW
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1324
While enabling the AOT analyzers, I noticed that marshalling
System.Typewas inherently not AOT-safe. Because this is a well known type, we can drop usingMarshalNonBlittable<T>for it (as this is just not AOT-safe at all), and hardcode the right marshalling stubs instead, since we do know the ABI type at compile time in this case.Opening this PR first to split the work. Will finish adding all AOT annotations in a follow up PR.