Enabled optional time validation in ChainTrustVaildator #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>
CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs
Outdated
Show resolved
Hide resolved
…oft/CoseSignTool into user/lemccomb/chainstatus # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
elantiguamsft
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to .NET made chain trust validation more strict about validity time on signing certificates. But some users need to allow signatures with expired certificates to pass validation.
This pull request adds an optional "allowOutdated" field to the ChainTrustValidator constructor, which allows certificates to pass chain trust validation after their "NotAfter" date unless they have a lifetime EKU.