Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from nuspec to package references #93

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

lemccomb
Copy link
Contributor

@lemccomb lemccomb commented Jun 13, 2024

Upgraded from .nuspec files to package references for NuGet packing for better .NET 8 compatibility.

@lemccomb lemccomb closed this Jun 14, 2024
@lemccomb lemccomb reopened this Jun 14, 2024
@elantiguamsft
Copy link
Contributor

Love this change, but will need to address the change to public signing from delay signing that was introduced in #91. Public sign is fine for the net core libs, but the netstandard2.0 libs (e.g. CoseSign1 et al) need to use delay signing so they can later be strong-name signed with the right key pair. Without this, the libs will not be consumable from some of our internal net framework projects that currently have a dependency on us.

@lemccomb lemccomb merged commit 5c5db9e into main Jun 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants