upgrade to .NET 8, add docs to package, add retry loop for revocation server #89

lemccomb · 2024-05-10T21:51:01Z

This PR does three things:

Upgrades CoseSignTool.exe and the test projects to .NET 8.0,
Copies the markdown documents from the repo into the downloadable release packages on GitHub and adds them to the NuSpec files so they will be included in any NuGet packages as well.
Adds a retry to the chain trust validator for the cases where the host fails to resolve a request to the certificate revocation server.

The main files of interest for review are ChainTrustValidator.cs, the project files, nuspec files, and dotnet.yml.
Other changes are mostly code style cleanup.

CoseSign1.Certificates.Tests/X509ChainTrustValidatorTests.cs

CoseHandler.Tests/CoseParserSignWithKeyProviderTests.cs

CoseIndirectSignature.Tests/IndirectSignatureFactoryTests.cs

CoseSign1.Certificates.Tests/X509Certificate2SigningKeyProviderTests.cs

CoseSign1.Certificates.Tests/X509CommonNameValidatorTests.cs

CoseHandler.Tests/CoseSignValidateTests.cs

CoseSign1.Tests/StreamExtensionsTests.cs

CoseHandler.Tests/CoseSignValidateTests.cs

This reverts commit fb149cb.

This reverts commit a17740e.

This reverts commit 9c26842.

This reverts commit 57b0e8e "proj fix" and all subsequent commits except 64d7826 "cleanup" and adds a workflow step to install the x64 runtime on MacOs # Conflicts: # CoseSignTool.tests/CoseSignTool.tests.csproj

CoseSignTool.Tests/ValidateCommandTests.cs

…eSignTool into user/lemccomb/net8

This directory name is incorrectly cased. Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

CoseSignTool.sln

remove dead code Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs

.github/workflows/dotnet.yml

Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

The check failed in Linux because the error message is worded differently. Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs

upgrade to .NET 8, add docs to package

7687d4c

github-actions bot assigned lemccomb May 10, 2024

github-advanced-security bot found potential problems May 10, 2024

View reviewed changes

CoseSign1.Certificates.Tests/X509ChainTrustValidatorTests.cs Fixed Show fixed Hide fixed

lemccomb added 6 commits May 10, 2024 15:08

remove platform specifier

3a56874

remove unnecessary variable

2f8ff45

remove platform target

1f0e980

Add osx-x64

65848f8

minor fix

12c4ef4

syntax update

6c9183e

github-advanced-security bot found potential problems May 13, 2024

View reviewed changes

CodeQL cleanup

a67df78

github-advanced-security bot found potential problems May 13, 2024

View reviewed changes

lemccomb added 18 commits May 13, 2024 13:57

fix proj file

57b0e8e

proj fix

d61bcca

cleanup

64d7826

re-apply platformtarget

9c26842

Stop signing test proj

a17740e

try pipeline fix

fb149cb

Revert "try pipeline fix"

01597e2

This reverts commit fb149cb.

Revert "Stop signing test proj"

b416fa6

This reverts commit a17740e.

Revert "re-apply platformtarget"

9f33b98

This reverts commit 9c26842.

Revert recent commits, fix workflow

d96518a

This reverts commit 57b0e8e "proj fix" and all subsequent commits except 64d7826 "cleanup" and adds a workflow step to install the x64 runtime on MacOs # Conflicts: # CoseSignTool.tests/CoseSignTool.tests.csproj

brew command syntax

3b62f87

task order

11f7c48

rosetta

0a50068

back to brew

db6297d

suppress error

f32a928

set dotnet root

4ba0b27

path info

3b59715

mac arm64 in proj

cb82bf8

lemccomb added 11 commits May 22, 2024 16:51

arm only

59d00ce

Use MsTest.sdk

6c64e4b

sln cfg

3cf64ab

specify arch

0003173

test by proj

6f8092e

typo

6e5cb33

x64

cbdbc8c

proj nopt sln

de5715d

build first

7d35c88

case

f88ec65

fixed folder name casing

4bf744c

github-advanced-security bot found potential problems May 24, 2024

View reviewed changes

actions-user and others added 6 commits May 24, 2024 01:43

Update changelog for release

36c8736

try sln

41cec3a

Merge branch 'user/lemccomb/net8' of https://github.com/microsoft/Cos…

4e854b4

…eSignTool into user/lemccomb/net8

back to proj, cleanup

355b0f7

showtestfailures

d33fa8d

Delete CoseSignTool.tests directory

e591076

This directory name is incorrectly cased. Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

JoeBussell reviewed May 24, 2024

View reviewed changes

CoseSignTool.sln Show resolved Hide resolved

lemccomb requested a review from JoeBussell May 28, 2024 20:33

Update dotnet.yml

c8d7ef2

remove dead code Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

elantiguamsft reviewed May 30, 2024

View reviewed changes

CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs Show resolved Hide resolved

elantiguamsft reviewed May 30, 2024

View reviewed changes

CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs Outdated Show resolved Hide resolved

elantiguamsft reviewed May 30, 2024

View reviewed changes

.github/workflows/dotnet.yml Show resolved Hide resolved

lemccomb added 3 commits May 30, 2024 14:25

Update CoseSignValidateTests.cs

7eed1f1

Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

Make only the targeted flags are present

7324d01

Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

removed error message check from test

cc42035

The check failed in Linux because the error message is worded differently. Signed-off-by: lemccomb <117306942+lemccomb@users.noreply.github.com>

elantiguamsft approved these changes May 31, 2024

View reviewed changes

CoseSign1.Certificates/Local/Validators/X509ChainTrustValidator.cs Show resolved Hide resolved

lemccomb merged commit 818cfdd into main May 31, 2024
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to .NET 8, add docs to package, add retry loop for revocation server #89

upgrade to .NET 8, add docs to package, add retry loop for revocation server #89

lemccomb commented May 10, 2024 •

edited

Loading

upgrade to .NET 8, add docs to package, add retry loop for revocation server #89

upgrade to .NET 8, add docs to package, add retry loop for revocation server #89

Conversation

lemccomb commented May 10, 2024 • edited Loading

lemccomb commented May 10, 2024 •

edited

Loading