Implement Cose_Hash_V support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure for hash storage and processing
…/microsoft/CoseSignTool into users/jstatia/cose_hash_v_update
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature/Extensions/CoseSign1MessageIndirectSignatureExtensions.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/IndirectSignatureFactoryTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/IndirectSignatureFactoryTests.cs
Dismissed
Show dismissed
Hide dismissed
…/microsoft/CoseSignTool into users/jstatia/cose_hash_v_update
JeromySt
commented
Feb 21, 2024
briankr-ms
reviewed
Feb 23, 2024
…erties to remove any structure order compatibility issues.
CoseIndirectSignature/Extensions/CoseSign1MessageIndirectSignatureExtensions.cs
Show resolved
Hide resolved
elantiguamsft
previously approved these changes
Feb 29, 2024
CoseIndirectSignature/Extensions/CoseSign1MessageIndirectSignatureExtensions.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature/Extensions/CoseSign1MessageIndirectSignatureExtensions.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
CoseIndirectSignature.Tests/CoseSign1MessageIndirectSignatureExtensionsTests.cs
Dismissed
Show dismissed
Hide dismissed
elantiguamsft
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of COSE_Hash_V for indirect signing
Rename everything away from Detached and to Indirect to reduce confusion.