Fix missing Microsoft.Bcl.Hash reference #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoseSign1 libraries were originally built for .NET Standard 2.1 and later downgraded to 2.0 for compatibility. Microsoft.Bcl.Hash is included in 2.1 but not 2.0, so with the downgrade, certain validation scenarios started to fail because they couldn't find Microsoft.Bcl.Hash. This PR adds the assembly as a dependence of CoseSign1.Abstractions, which fixes the broken scenario. It also fixes some usage text that was appearing incorrectly, or in some cases not being displayed at all.
elantiguamsft
previously approved these changes
Jan 12, 2024
elantiguamsft
approved these changes
Jan 12, 2024
65b267b to
6b75e10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoseSign1 libraries were originally built for .NET Standard 2.1 and later downgraded to 2.0 for compatibility. Microsoft.Bcl.Hash is included in 2.1 but not 2.0, so with the downgrade, certain validation scenarios started to fail because they couldn't find Microsoft.Bcl.Hash. This PR adds the assembly as a dependence of CoseSign1.Abstractions, which fixes the broken scenario.
It also fixes some usage text that was appearing incorrectly, or in some cases not being displayed at all.