implement detached signature factory, tests and helper extension methods. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods for validaiton of detached signature objects
Signed-off-by: JeromySt <thelotrs@hotmail.com>
|
@microsoft-github-policy-service agree company="Microsoft" |
Signed-off-by: JeromySt <thelotrs@hotmail.com>
lemccomb
reviewed
Oct 2, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
lemccomb
reviewed
Oct 2, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
lemccomb
reviewed
Oct 2, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
lemccomb
reviewed
Oct 2, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
lemccomb
reviewed
Oct 2, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
lemccomb
reviewed
Oct 2, 2023
lemccomb
reviewed
Oct 2, 2023
lemccomb
reviewed
Oct 2, 2023
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
…icrosoft/CoseSignTool into user/jstatia/detachedsignature
nileshbh
reviewed
Oct 3, 2023
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Outdated
Show resolved
Hide resolved
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1/Extensions/CoseSign1MessageDetachedSignatureExtensions.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
CoseSignTool/CoseSign1.Tests/CoseSign1MessageDetachedSignatureExtensionsTests.cs
Fixed
Show fixed
Hide fixed
| /// <returns>True if the detached signature in the CoseSign1Message matches the signature of the artifact bytes; False otherwise.</returns> | ||
| private static bool SignatureMatchesInternal(this CoseSign1Message? @this, ReadOnlyMemory<byte>? artifactBytes = null, Stream? artifactStream = null) | ||
| { | ||
| if (!@this.TryGetHashAlgorithm(out HashAlgorithm? hasher)) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
|
|
||
| // test null object case | ||
| detachedSignature = null; | ||
| CoseSign1MessageDetachedSignatureExtensions.SignatureMatches(detachedSignature, stream2).Should().BeFalse(); |
Check failure
Code scanning / CodeQL
Dereferenced variable is always null
|
|
||
| // test null object case | ||
| detachedSignature = null; | ||
| CoseSign1MessageDetachedSignatureExtensions.SignatureMatches(detachedSignature, randomBytes).Should().BeFalse(); |
Check failure
Code scanning / CodeQL
Dereferenced variable is always null
|
|
||
| // test null object case | ||
| detachedSignature = null; | ||
| CoseSign1MessageDetachedSignatureExtensions.TryGetHashAlgorithm(detachedSignature, out hashAlgorithm).Should().BeFalse(); |
Check failure
Code scanning / CodeQL
Dereferenced variable is always null
| { | ||
| hasher = null; | ||
|
|
||
| if (!TryGetDetachedSignatureAlgorithm(@this, out HashAlgorithmName algorithmName)) |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
lemccomb
approved these changes
Oct 3, 2023
nileshbh
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the detached signature factory work in CoseSign1 to facilitate a detached signature embedded CoseSign1 object for use in various *BOM scenarios to be used with Azure CTS.